-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[indexer-alt] pruning tests for kv_epoch_ends and pipelines that don't need CpSeqeuenceNumbers
#20925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
wlmyng
force-pushed
the
indexer-alt-prune-tests-epoch
branch
from
January 19, 2025 00:45
59bc8ef
to
fd7e3e1
Compare
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 19, 2025 00:46 — with
GitHub Actions
Inactive
wlmyng
force-pushed
the
indexer-alt-prune-tests-epoch
branch
from
January 21, 2025 18:44
fd7e3e1
to
d5cc1b7
Compare
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 21, 2025 18:44 — with
GitHub Actions
Inactive
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 22, 2025 01:01 — with
GitHub Actions
Inactive
wlmyng
changed the title
[indexer-alt] pruning tests for epoch-related pipelines
[indexer-alt] pruning tests for kv_epoch_ends and pipelines that don't need Jan 22, 2025
CpSeqeuenceNumbers
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 22, 2025 01:15 — with
GitHub Actions
Inactive
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 22, 2025 01:18 — with
GitHub Actions
Inactive
lxfind
reviewed
Jan 22, 2025
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 22, 2025 01:35 — with
GitHub Actions
Inactive
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 22, 2025 01:41 — with
GitHub Actions
Inactive
lxfind
approved these changes
Jan 22, 2025
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 22, 2025 05:44 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend
TestCheckpointDataBuilder
to advance an epoch by creating an advance epoch tx with or without the SystemEpochInfoEvent depending onsafe_mode
. Usage:I had originally considered extending the current tx workflow of
builder.start_transaction()
to then.advance_epoch().build_checkpoint()
, but ultimately kept it standalone as we'd largely be discarding modifications if any made to the current transaction. A user can still create multiple transactions for the checkpoint, and after.finish_transaction()
, would calladvance_epoch()
instead ofbuild_checkpoint()
.This saves us from having to use simulacrum to test epoch-boundary behavior (and dealing with potential flakiness)
Test plan
New tests written
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.