Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #21027

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Update CONTRIBUTING.md #21027

merged 1 commit into from
Jan 31, 2025

Conversation

stefan-mysten
Copy link
Contributor

@stefan-mysten stefan-mysten commented Jan 31, 2025

Description

This PR updates the contributing guideline to be more comprehensive, and also exposes it to the main README file by linking it.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 1:42am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2025 1:42am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2025 1:42am

Copy link
Contributor

@ronny-mysten ronny-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks Stefan!

@stefan-mysten stefan-mysten merged commit 88f98b3 into main Jan 31, 2025
52 checks passed
@stefan-mysten stefan-mysten deleted the stefan-mysten-patch-1 branch January 31, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants