rpc-alt: resolveNameServiceAddress #21161
Open
+1,394
−369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
commented
Feb 10, 2025
There was a problem hiding this comment.
The last usage of internal_context disappeared during the refactorings to have load_latest return an Object instead of StoredObject -- we can add it back if we need it (with_internal_context is still around).
There was a problem hiding this comment.
Nothing has changed in this file -- it's just been re-ordered (and combined with its unit tests).
amnn
force-pushed
the
amnn/rpc-test-refactor
branch
from
6346807 to
7ba0aa9
Compare
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
This was referenced Feb 11, 2025
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
7 tasks
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
force-pushed
the
amnn/rpc-test-refactor
branch
from
1b0bcab to
24120c7
Compare
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
force-pushed
the
amnn/rpc-test-refactor
branch
from
24120c7 to
a2dcf95
Compare
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
manolisliolios
approved these changes
Feb 13, 2025
amnn
force-pushed
the
amnn/rpc-test-refactor
branch
from
a2dcf95 to
a88ee51
Compare
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
7 tasks
## Description Don't exclude framework tables from `sui-indexer-alt-schema`, so that they can be used in the reader without the reader having to depend on the framework. ## Test plan These tables will be used in an upcoming change.
## Description Pull out `sui-name-service` from `sui-json-rpc`, because it is used in multiple other crates. This change also re-orders the contents of the `name_service` module and brings its tests into one file. ## Test plan CI
## Description Simplifying the helper function that finds the latest version of an object and returns it to return the serialized form, rather than the `StoredObject`. This is based on an observation that: - All the callers to this function eventually deserialize it. - The other fields on `StoredObject` (id and version) are available on the deserialized object as well. ## Test plan CI
## Description Adds support for SuiNS name resolution. ## Test plan New E2E tests, based on `FullCluster`: ``` sui$ cargo nextest run -p sui-indexer-alt-e2e-tests \ -- test_resolve name_service ```
amnn
force-pushed
the
amnn/rpc-test-refactor
branch
from
a88ee51 to
4a958cb
Compare
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an implementation for
suix_resolveNameServiceAddressto rpc-alt. Also factors out thename_servicemodule fromsui-json-rpcinto its own crate.As part of this change, the
watermarksandcp_sequence_numberstables introduced by the indexing framework are exposed throughsui-indexer-alt-schema, so that readers can read from these tables without taking a dependency on the (writer) framework.Test plan
New E2E tests:
Stack
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.