Change p2p default port to 8084 #21162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
mwtian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
johnjmartin
reviewed
Feb 10, 2025
| @@ -40,7 +40,7 @@ pub struct P2pConfig { | |||
| } | |||
|
|
|||
| fn default_listen_address() -> SocketAddr { | |||
| "0.0.0.0:8080".parse().unwrap() | |||
| "0.0.0.0:8084".parse().unwrap() | |||
There was a problem hiding this comment.
Great context. Do you have opinions on how this should be updated?
There was a problem hiding this comment.
I can't think of any issues this would cause for an operator who isn't explicitly setting this value
johnjmartin
approved these changes
Feb 10, 2025
Updated the description. I meant the sui/crates/sui-config/src/node.rs Line 517 in 01257bd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
8084 is mentioned to be the default p2p port in docs: https://docs.sui.io/guides/operator/validator-tasks#connectivity
And validator / transaction RPC port defaults to 8080 already.
So changing the default p2p port from 8080 to 8084 in
P2pConfig.I believe the change is backward compatible but lmk otherwise.
Test plan
CI
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.