Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO MERGE YET][indexer-alt] modify coin balance bucket index to sort object id in descending order #21187

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emmazzz
Copy link
Contributor

@emmazzz emmazzz commented Feb 12, 2025

Description

As titled. This way we can more efficiently fetch coin balances and use the index to its fullest potential like in #20931.

Test plan

Existing tests.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 0:48am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 0:48am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 0:48am

@emmazzz emmazzz temporarily deployed to sui-typescript-aws-kms-test-env February 12, 2025 00:42 — with GitHub Actions Inactive
@emmazzz emmazzz force-pushed the emma/indexer-alt-coin-index-order branch from 7ed082f to feea443 Compare February 12, 2025 00:46
@emmazzz emmazzz temporarily deployed to sui-typescript-aws-kms-test-env February 12, 2025 00:46 — with GitHub Actions Inactive
@emmazzz emmazzz requested review from amnn, gegaowp and wlmyng February 12, 2025 00:49
@emmazzz emmazzz changed the title [indexer-alt] modify coin balance bucket index to sort object id in descending order [NO MERGE YET][indexer-alt] modify coin balance bucket index to sort object id in descending order Feb 12, 2025
@emmazzz emmazzz marked this pull request as draft February 12, 2025 01:02
Copy link
Contributor

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this is good to run proactively now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants