-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulator network configuration and stress test #4677
Conversation
1747908
to
3c8ba2f
Compare
@mystenmark the BenchmarkStats object that is returned by the BenchDriver has |
I took a look at that, but apparently the errors that I'm seeing aren't resulting in client facing errors, so they don't show up in the BenchmarkStats - I'll need to find some other way to instrument those. I added a simple assert for 0 errors for now. We can add longer tests, but I'll need to set up a nightly job for longer tests - I don't want to add very long running tests to CI. |
b07dd44
to
b2d18c6
Compare
b2d18c6
to
e3e56ec
Compare
e3e56ec
to
82b16f5
Compare
Support for configuring the network using the simulator's SimConfig struct. (See MystenLabs/mysten-sim#3 for background).
Adds a new test which runs the stress tester inside the simulator. This test can currently expose various bugs/errors when run with a higher latency network. The default target that is checked in uses low latency and thus will pass in CI.
@sadhansood is there an easy way to get a failure signal from the BenchDriver, e.g. a callback every time a transaction fails? Right now I don't have a good way to make this test fail if errors are encountered.