[wallet-ext] Add Origin Byte NFTs (v0.5.0) support #5564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use genesis.blob to set up remote bench * add AuthorityAggregatorBuilder
* spawn task * add error logs in AA
Narwhal consensus latency is 5~6s in private testnet. Using a timeout of 5s is too low. Increasing the default value to avoid timeout errors. These defaults are used by AuthorityClients.
* revert flat vm fee while we make it easier for users
* splitting local network from client cli * Removing gateway mentions * Updates for gateway deprecation * Update json-rpc.md * Updates for gateway deprecation * Updates for gateway deprecation * Update sui-json.md * Updates for gateway deprecation * Update sui-local-network.md * Update sui-local-network.md * Update doc/src/build/comms.md Co-authored-by: Lu Zhang <[email protected]> * Update doc/src/build/devnet.md Co-authored-by: Lu Zhang <[email protected]> * Update doc/src/build/fullnode.md Co-authored-by: Lu Zhang <[email protected]> * Update doc/src/build/fullnode.md Co-authored-by: Lu Zhang <[email protected]> * Update doc/src/build/fullnode.md Co-authored-by: Lu Zhang <[email protected]> * Updates per tech review * Update fullnode.md * Update fullnode.md * Update json-rpc.md * Update fullnode.md * Update fullnode.md * Additional changes for gateway deprecation Co-authored-by: Lu Zhang <[email protected]>
oribyts
changed the title
|
Hi @oribyts, please open PRs to contribute against the main branch rather than devnet. Looks like you may need to rebase to release .13 as well |
|
@randall-Mysten I've decided to create another PR to prevent conflicts resolving (PR is not a big and was easier to move code): #5845 |
|
Hi @oribyts Please also submit PRs to main instead of devnet. Thank you. Create a fork of Mysten\sui main and then submit create the PR from your fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support of new version of OriginByte NFT protocol.
SUI-wallet.mov
The main difference with previous PR is adding external library and response parser, which will be helpful if the data structure will change again.