Fix dynamic field indexer #7131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
…field value can be both object and value, which don't always have a id.
mystenmark
approved these changes
Jan 4, 2023
|
This LGTM but it would be great to have unit tests for some of these trickier |
I will add more unit test in the cherrypick PR |
patrickkuo
added a commit
that referenced
this pull request
Jan 4, 2023
Fix incorrect checking of object IDs for dynamic fields Co-authored-by: patrick <[email protected]>
patrickkuo
added a commit
that referenced
this pull request
Jan 5, 2023
Fix incorrect checking of object IDs for dynamic fields Co-authored-by: patrick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect checking of object IDs for dynamic fields