-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sui CLI] - Add dynamic field query support to Sui CLI #7151
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
crates/sui/src/client_commands.rs
Outdated
"Name", "Type", "Object Type", "Object Id", "Version", "Digest" | ||
)?; | ||
writeln!(writer, "{}", ["-"; 165].join(""))?; | ||
loop{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this loop is printing the same data over and over again if next_cursor is not None, until out of memory.
The loop to fetch the data pages should happen in line 517 instead and pass a Dec to here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @siomari
5599d11
to
777874d
Compare
This PR adds dynamic field query in Sui CLI
Example:
The example is from a capy that has some accessories which have dynamic fields.
Request:
sui client dynamic-field 0x6749be6620208f34d7fd175d886daf5b2d45eebd
Response: