[sui-framework] Remove "delegate" and replace with stake

[tzakian]

This does a large rename of "delegation/delegate" (etc) to the equivalent "stake" name, e.g., request_add_delegation becomes request_add_stake.

Move

Entry functions renamed (all within sui_system.move):

request_add_delegation ~> request_add_stake
request_add_delegation_mul_coin ~> request_add_stake_mul_coin
request_add_delegation_with_locked_coin ~> request_add_stake_with_locked_coin
request_add_delegation_with_mul_locked_coin ~> request_add_stake_with_mul_locked_coin
request_withdraw_delegation ~> request_withdraw_stake

Move Object fields

StakingPool::pending_delegation ~> pending_stake
StakedSui::delegation_activation_epoch ~> stake_activation_epoch 

Sui types

This renames a couple sui types since they no longer made sense to be called what they were:

DelegatedStake ~> Stake
DelegationStatus ~> StakeStatus

This then performs the core set of renamings to make the system happy with this. So there are still a number of functions in Rust and Typescript that will contain their old delegation name.

Note that on the typescript side we keep DelegatedStake since (1) there was already a type called Stake (which meant something else) and in the context that I could see it being used it appeared as though DelegatedStake really did mean "this is my stake that I have delegated to this validator."

Test Plan

Make sure existing tests still pass.

---

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

• user-visible impact
• breaking change for a client SDKs
• breaking change for FNs (FN binary must upgrade)
• breaking change for validators or node operators (must upgrade binaries)
• breaking change for on-chain data layout
• necessitate either a data wipe or data migration

Release notes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
explorer	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 10, 2023 at 6:55PM (UTC)
explorer-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 10, 2023 at 6:55PM (UTC)
wallet-adapter	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 10, 2023 at 6:55PM (UTC)

[patrickkuo]

the governance api PR #8848 has some of the same renaming changes on the RPC layer, SDK and the FE apps, this will create quite a bit of conflicts, can we put this on hold 🙏?

[Jordan-Mysten]

We should really just remove this method.

[tzakian]

To keep things clean I might leave this in for now so this is a strict renaming pass, but will do a fast follow to remove this.

[emmazzz]

But I believe this function is used in our sui-transaction-builder as well as sui-rosetta:

sui/crates/sui-transaction-builder/src/lib.rs

Line 663 in ffc34df

ADD_DELEGATION_MUL_COIN_FUN_NAME

cc @patrickkuo

[tzakian]

The plan is to wait for #9058 to land, and once it does this PR will be rebased on that and then landed.

In the meantime please review and let me know if there is anywhere I have missed or that you think an error was made.

[emmazzz]

stake stake 🤣 but let's land the PR first and fix this later

[tzakian]

Changed this at the same time as I was reverting the safe_tests file.

[emmazzz]

We need to revert the changes to one file but other than that LGTM, approving to unblock. Thank you so much! @tzakian