Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BN254 groth16 verifier #9196

Merged
merged 18 commits into from
Mar 14, 2023
Merged

BN254 groth16 verifier #9196

merged 18 commits into from
Mar 14, 2023

Conversation

jonas-lj
Copy link
Contributor

Description

Add a Move API for verifying Groth16 zero-knowledge proofs with the BN254 elliptic curve construction.

Test Plan

All tests pass.

@vercel
Copy link

vercel bot commented Mar 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated
explorer ⬜️ Ignored (Inspect) Mar 14, 2023 at 4:33PM (UTC)
explorer-storybook ⬜️ Ignored (Inspect) Mar 14, 2023 at 4:33PM (UTC)
wallet-adapter ⬜️ Ignored (Inspect) Mar 14, 2023 at 4:33PM (UTC)

@jonas-lj jonas-lj requested review from benr-ml and kchalkias March 13, 2023 09:00
@jonas-lj jonas-lj requested a review from benr-ml March 13, 2023 13:14
kchalkias
kchalkias approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@kchalkias kchalkias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@jonas-lj jonas-lj force-pushed the jonas/bn254_groth16 branch from 1929261 to dd1f513 Compare March 13, 2023 17:09
kchalkias
kchalkias reviewed Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@kchalkias kchalkias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonas-lj is the simtest error irrelevant?
--- STDERR: sui::bin/sui cli_tests::test_move_call_args_linter_command ---

@jonas-lj jonas-lj force-pushed the jonas/bn254_groth16 branch from dd1f513 to a237520 Compare March 13, 2023 21:31
kchalkias
kchalkias reviewed Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@kchalkias kchalkias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the simtest still irrelevant and we could merge or not?

@jonas-lj jonas-lj force-pushed the jonas/bn254_groth16 branch 3 times, most recently from 1d9f1b1 to 6b766a4 Compare March 14, 2023 12:09
@jonas-lj jonas-lj force-pushed the jonas/bn254_groth16 branch from 6b766a4 to e38a969 Compare March 14, 2023 13:22
@jonas-lj jonas-lj merged commit 894dfb5 into main Mar 14, 2023
@jonas-lj jonas-lj deleted the jonas/bn254_groth16 branch March 14, 2023 16:54
kchalkias
kchalkias reviewed Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@kchalkias kchalkias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing thanks for the quick response!

kchalkias
kchalkias reviewed Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@kchalkias kchalkias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves #9278 thanks!

@kchalkias kchalkias mentioned this pull request Mar 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kchalkias kchalkias kchalkias approved these changes

@benr-ml benr-ml benr-ml approved these changes

@randall-Mysten randall-Mysten Awaiting requested review from randall-Mysten

@ronny-mysten ronny-mysten Awaiting requested review from ronny-mysten ronny-mysten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonas-lj @kchalkias @benr-ml