[sui-framework] separate sui-framework into two packages #9618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
github-actions
bot
added
the
Type: Documentation
emmazzz
force-pushed
the
separate_framework
branch
from
a600257 to
f3f1386
Compare
emmazzz
force-pushed
the
separate_framework
branch
from
f3f1386 to
cb13fce
Compare
emmazzz
requested review from
lxfind,
bmwill,
sblackshear,
tnowacki,
tzakian and
amnn
tnowacki
reviewed
Mar 21, 2023
| if module_id != &ModuleId::new(SUI_FRAMEWORK_ADDRESS, SUI_SYSTEM_MODULE_NAME.to_owned()) | ||
| && is_mutable_clock(view, param) | ||
| { | ||
| if is_mutable_clock(view, param) { |
There was a problem hiding this comment.
What happened to this case?
There was a problem hiding this comment.
That function was moved out of sui system module and made private so not an entry fun anymore
emmazzz
force-pushed
the
separate_framework
branch
2 times, most recently
from
5d760c4 to
47fd066
Compare
bmwill
reviewed
Mar 21, 2023
Comment on lines
+942
to
+948
| ( | ||
| SuiSystem::as_modules(), | ||
| SuiSystem::transitive_dependencies(), | ||
| ), |
There was a problem hiding this comment.
You'll need to add this as a parameter in the call to create_genesis_context above as well on like 923.
There was a problem hiding this comment.
Addressed this in the latest commit
| @@ -4,7 +4,7 @@ version = "0.0.0" | |||
|
|
|||
| [dependencies] | |||
| Examples = { local = "../object_basics" } | |||
| Sui = { local = "../../../../../sui-framework" } | |||
| Sui = { local = "../../../../../sui-framework/packages/sui-framework" } | |||
There was a problem hiding this comment.
how many ../'s can we have lol
emmazzz
force-pushed
the
separate_framework
branch
from
47fd066 to
554b2ef
Compare
lxfind
approved these changes
Mar 21, 2023
amnn
reviewed
Mar 21, 2023
| @@ -3523,7 +3535,7 @@ mod tests { | |||
| } | |||
|
|
|||
| #[cfg(msim)] | |||
| pub mod sui_framework_injection { | |||
| pub mod sui_system_injection { | |||
| @@ -4,7 +4,7 @@ version = "0.0.0" | |||
|
|
|||
| [dependencies] | |||
| Examples = { local = "../object_basics" } | |||
| Sui = { local = "../../../../../sui-framework" } | |||
| Sui = { local = "../../../../../sui-framework/packages/sui-framework" } | |||
There was a problem hiding this comment.
Changes here seem right to me as well!
tzakian
approved these changes
Mar 21, 2023
emmazzz
force-pushed
the
separate_framework
branch
from
e70f90b to
b0be221
Compare
emmazzz
force-pushed
the
separate_framework
branch
from
b0be221 to
ec4b6b6
Compare
emmazzz
force-pushed
the
separate_framework
branch
from
ec4b6b6 to
f87cf45
Compare
emmazzz
force-pushed
the
separate_framework
branch
from
f87cf45 to
ba1f876
Compare
bmwill
approved these changes
Mar 22, 2023
benr-ml
pushed a commit
that referenced
this pull request
Mar 22, 2023
## Description This PR splits our `sui-framework` Move code into two packages, one for modules in `governance` folder and one for the rest of the modules. Most of the changes here are pretty mechanical, mostly about making sure we use the right package(s) and correct path. ## Test Plan Existing tests should pass. --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [x] user-visible impact - [x] breaking change for a client SDKs - [x] breaking change for FNs (FN binary must upgrade) - [x] breaking change for validators or node operators (must upgrade binaries) - [x] breaking change for on-chain data layout - [x] necessitate either a data wipe or data migration ### Release notes `sui-framework` Move package is split up into two packages, `sui-framework` and `sui-system`. `sui-system` contains modules that were in the `governance` folder.
gegaowp
added a commit
that referenced
this pull request
Mar 23, 2023
## Description Fixed CI, it was b/c the splitting that happened in #9618 A couple of other changes: - added checkpoint read test around epoch boundary - add timeout to wait_until ## Test Plan integration test both locally and on CI
danaiballa
pushed a commit
that referenced
this pull request
Mar 23, 2023
## Description Fixed CI, it was b/c the splitting that happened in #9618 A couple of other changes: - added checkpoint read test around epoch boundary - add timeout to wait_until ## Test Plan integration test both locally and on CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR splits our
sui-frameworkMove code into two packages, one for modules ingovernancefolder and one for the rest of the modules. Most of the changes here are pretty mechanical, mostly about making sure we use the right package(s) and correct path.Test Plan
Existing tests should pass.
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes
sui-frameworkMove package is split up into two packages,sui-frameworkandsui-system.sui-systemcontains modules that were in thegovernancefolder.