Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sew 25 replace node runtime with bun #377

Merged
merged 70 commits into from
Feb 3, 2025
Merged

feat: sew 25 replace node runtime with bun #377

merged 70 commits into from
Feb 3, 2025

Conversation

Tzal3x
Copy link
Collaborator

@Tzal3x Tzal3x commented Jan 30, 2025 •
edited
Loading

The core feature of Bun is that it uses the JavascriptCore instead of V8.
It's a drop-in replacement for node.js.

Benefits

Changelog

  • Replace pnpm with bun wherever it applied.
  • Update github actions
  • Remove the Codspeed integration. There is no benefit having it around, we were only using it for file decompression checks.
  • Update package.json files. A lot of scripts defined there are not used, so why keep them around?
  • Move static files to the service worker: refactor: sew 30 move static files from common lib to the service worker #379

Tzal3x added 30 commits January 28, 2025 14:52
@Tzal3x
Rename custom_blocklist_checker to blocklist_checker.ts
3eb98bd
@Tzal3x
Create create_vercel_blocklist_checker and create_redis_blocklist_che…
f1b5e88 
…cker
@Tzal3x
refactor: use BlocklistChecker interface & add VercelBlocklistChecker
338553b
@Tzal3x
Add docstring to VercelVlokclistChecker
0e25b96
@Tzal3x
Improve docstrings
926077e
@Tzal3x
Rename VercelBlocklistChecker to VercelEdgeConfigBlocklistChecker
6d8708b
@Tzal3x
Create BlocklistCheckerFactory
427111b
@Tzal3x
Create RedisBlocklistChecker - WIP
5aa18d3
@Tzal3x
Hash check if the SET walrus-sites-blocklist contains the provided id
dc5fa37
@Tzal3x
Deduce storage variant from environment variables
a534733
@Tzal3x
Fix instanstiateBlocklistChecker
a2dc633
@Tzal3x
Fix configuration_loader logic
dff8e4c
@Tzal3x
Rename BlocklistChecker.check to isBlocked
168db02
@Tzal3x
Rename instantiateBlocklistChecker to build
be6056f
@Tzal3x
refactor: use object literal mapping instead of switch
0c98cf7 
This is better than a non-exhaustive switch statement.
Plus it follows the Open/Closed Principle - extend by
adding to map, not modifying code.

The main tradeoff is that it's slightly more abstract
than a switch statement. It becomes more valuable as
we add more variants.
@Tzal3x
Replace assert with exceptions
f2775bc 
asserts in typescript only log the errors,
they don't throw an exception as in other
languages.
@Tzal3x
Remove console log leftover
a23bf90
@Tzal3x
Redis client: set connected = false when closing connection
e831673
@Tzal3x
Use RedisClient.isReady instead of custom connected field
badab17
@Tzal3x
refactor: move source files to a src/ directory
fcdf169 
Separates the configuration/setup files and
middleware code from the source files.
@Tzal3x
Fix config loader imports
b619695
@Tzal3x
Move url_fetcher_factory to src/
9a35af6
@Tzal3x
Add web_analytics.ts to src/
96827e6
@Tzal3x
Fix import error
28a11cd
@Tzal3x
Fix import error
f80f21b
@Tzal3x
Create a RedisClientFacade
e3f37d5
@Tzal3x
Rename file: redis facade to redis client facade
e6a99e8
@Tzal3x
Move StorageVariants to enums.ts
360f5b0
@Tzal3x
Create abstract list checker
4651956
@Tzal3x
Create an allowlist_checker
c5e87f8
giac-mysten
giac-mysten reviewed Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@giac-mysten giac-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a first pass of comments 🙏

portal/server/next-env.d.ts Outdated Show resolved Hide resolved
portal/server/package.json Outdated Show resolved Hide resolved
portal/common/tsconfig.json Show resolved Hide resolved
portal/worker/pnpm-lock.yaml Outdated Show resolved Hide resolved
portal/worker/README.md Show resolved Hide resolved
portal/vercel.json Show resolved Hide resolved
@Tzal3x Tzal3x force-pushed the alextzimas/sew-25-replace-node-runtime-with-bun branch from 7b8a0ed to aad7ca7 Compare January 31, 2025 13:35
@Tzal3x Tzal3x marked this pull request as ready for review January 31, 2025 13:49
giac-mysten
giac-mysten approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@giac-mysten giac-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's try this out!

@Tzal3x Tzal3x merged commit 4cc9ac1 into main Feb 3, 2025
20 checks passed
@Tzal3x Tzal3x deleted the alextzimas/sew-25-replace-node-runtime-with-bun branch February 3, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giac-mysten giac-mysten giac-mysten approved these changes

@chariskms chariskms Awaiting requested review from chariskms

Assignees

@Tzal3x Tzal3x

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tzal3x @giac-mysten