Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for 'Gitlab::ObjectifiedHash#merge' #576

Closed
wants to merge 1 commit into from
Closed

Add support for 'Gitlab::ObjectifiedHash#merge' #576

wants to merge 1 commit into from

Conversation

rymai
Copy link

@rymai rymai commented Jul 9, 2020

This should fix #574.

@rymai rymai mentioned this pull request Jul 9, 2020
Closed
@NARKOZ
Copy link
Owner

NARKOZ commented Jul 12, 2020

Thank you for the PR. I've allowed proxying to hash methods in 242cf2d with a warning message.

I don't want to overcomplicate Gitlab::ObjectifiedHash with redundant functionality.

@NARKOZ NARKOZ closed this Jul 12, 2020
@rymai rymai deleted the 574-fix-missing-merge-method branch July 13, 2020 08:21
@rymai
Copy link
Author

rymai commented Jul 13, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

method_missing': undefined method merge'
2 participants
@rymai @NARKOZ