Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Card images stretched after v5.10.0 #1264

Closed
aboydnw opened this issue Nov 19, 2024 · 1 comment
Closed

[Bug] Card images stretched after v5.10.0 #1264

aboydnw opened this issue Nov 19, 2024 · 1 comment
Assignees
@dzole0311
Labels
P3 Place in the backlog so we don't lose track regression Signifies a regression issue found during testing

Comments

@aboydnw
Copy link
Contributor

aboydnw commented Nov 19, 2024

Context

URL: https://staging.earth.gov/ghgcenter/stories

Blocking a release? (y/n):

Regression issue? (y/n): y

Priority: P3

Steps to reproduce the issue

  1. compare the staging site or v5.10 with production
@aboydnw aboydnw added P3 Place in the backlog so we don't lose track regression Signifies a regression issue found during testing labels Nov 19, 2024
@aboydnw
Copy link
Contributor Author

aboydnw commented Nov 19, 2024

potentially due to #1244

@dzole0311 dzole0311 self-assigned this Nov 20, 2024
@dzole0311 dzole0311 mentioned this issue Nov 20, 2024
Merged
dzole0311 added a commit that referenced this issue Nov 21, 2024
@dzole0311
Remove minHeight prop (#1265)
14fc8ea 
**Related Ticket:** #1264

### Description of Changes
Removed minHeight prop to avoid undesired card behavior. The css prop
was introduced here: #1244

### Notes & Questions About Changes
_{Add additonal notes and outstanding questions here related to changes
in this pull request}_

### Validation / Testing
1. Open the stories page where there are card components
2. Verify that the images in the cards no longer have a minHeight
property
4. Verify that the card layout appears consistent and the image heights
are reduced compared to the previous behavior on v10.0.0

Or see the Air Quality card here:

- Before: https://deploy-preview-1250--veda-ui.netlify.app/stories
- After: https://deploy-preview-1265--veda-ui.netlify.app/stories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dzole0311 dzole0311

Labels
P3 Place in the backlog so we don't lose track regression Signifies a regression issue found during testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dzole0311 @aboydnw