Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookie Consent Alert #953

Closed
5 tasks
aboydnw opened this issue May 10, 2024 · 3 comments
Closed
5 tasks

Cookie Consent Alert #953

aboydnw opened this issue May 10, 2024 · 3 comments
Assignees
@faustoperez @snmln
Labels
ui design

Comments

@aboydnw
Copy link
Contributor

aboydnw commented May 10, 2024 •
edited
Loading

Context

We use cookies to track usage with google analytics. Instances that use google analytics should have a cookie banner to give users the option to reject cookies.

Acceptance Criteria

  • Given that an instance has turned on the cookie banner, when a user visits that dashboard and has not previously provided an explicit response to the cookie alert, then they are presented with a cookie alert
  • Given a user visits an instance with the cookie alert who has not previously accepted the use of cookies when they ACCEPT cookies then we continue to track using google analytics
  • Given a user visits and instance with the cookie alert who has not previously accepted the use of cookies when they REJECT the use of cookies then we don't track their usage with google analytics
  • Any links in the alert content open in new tabs
  • If the user elects to close the alert without making an explicit selection, we assume that as a yes and continue collecting GA data, but ask the user again the next time they visit the site

Related Tickets
@faustoperez faustoperez self-assigned this May 13, 2024
@faustoperez
Copy link

Assigning this to myself

@snmln snmln self-assigned this Aug 26, 2024
@aboydnw aboydnw changed the title Cookie Consent Form Cookie Consent Alert Aug 27, 2024
@aboydnw
Copy link
Contributor Author

aboydnw commented Aug 27, 2024

@snmln I made some tweaks to the AC based on the convo in the PR, let me know if anything looks out of place

@snmln
Copy link
Contributor

snmln commented Sep 6, 2024

Linking PR: #1127

@aboydnw aboydnw mentioned this issue Sep 24, 2024
Merged
@snmln snmln closed this as completed Sep 26, 2024
@hanbyul-here hanbyul-here mentioned this issue Sep 26, 2024
Merged
dzole0311 added a commit that referenced this issue Oct 2, 2024
@dzole0311
Make cookie consent component not to receive mouse events when closed (…
b00db6e 
…#1177)

**Related Ticket:** #953 

### Description of Changes
Make cookie consent component not to receive mouse events when closed.

### Notes & Questions About Changes
This might be able to be resolved with #1170 , but here is a quick fix.


### Validation / Testing
Go to
https://veda-ui.netlify.app/exploration?datasets=%5B%5D&taxonomy=%7B%7D
, close cookie consent form and try to add datasets. The button click is
blocked because we are hiding the component only with opacity. (And
check the same work flow on this PR's preview)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@faustoperez faustoperez

@snmln snmln

Labels
ui design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@faustoperez @snmln @aboydnw