-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELEASE] Bump minor to v5.8.0 #1167
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@aboydnw @hanbyul-here Created a temporary deploy preview for GHG for manual validation and testing purposes since this release includes alot and many patches. Hoping we can do some manual validation here before merging this PR and cutting the actual release to reduce amount of patches to follow US-GHG-Center/veda-config-ghg#610 |
@slesaad If you have time, I will appreciate your manual testing to see if this release includes all the changes included in the patch and not introducing regressions. |
5_8_0_colormap_jotai.movSame problem @hanbyul-here mentioned above with colormap Posterior Total not working correctly (bug) and Jotai devtools present? |
Jotai devtool doesn't seem to be introduced by this release. It shows up on the main branch too https://ghg-demo.netlify.app/exploration?datasets=%5B%5D&taxonomy=%7B%7D - and probably gets turned off when being deployed with production flag (https://jotai.org/docs/tools/devtools) |
I thought it might be for all GOSAT datasets and I thought maybe something about layers with only one data point break the colorbar, but for some reason the uncertainty layers work fine. In this video I first show production with all the GOSAT layers working, then the deploy preview where the uncertainty layers work as well. |
PR with fix here for colormap now showing up |
Posting the Slack message here for reference. The main issue with the I re-generated the colormaps from the VEDA back-end so it should now work as expected. Also the The GHG test deployment is also updated with the latest commit, so we can re-test: https://deploy-preview-610--ghg-demo.netlify.app/exploration |
Related to bug seen in Release PR [here](#1167 (comment)) Fix on Local: ![Screenshot 2024-09-23 at 5 03 18 PM](https://github.com/user-attachments/assets/60cc5327-14e1-4725-a66b-18a04fc23087)
🎉 Features
🚀 Improvements
🐛 Fixes