Deprecate old explore page, Mapbox component #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hanbyul-here
changed the title
hanbyul-here
force-pushed
the
deprecate-old-explore
branch
from
94126b5 to
cfc39b6
Compare
hanbyul-here
force-pushed
the
deprecate-old-explore
branch
from
8bf149c to
164e5b2
Compare
|
The ts-error is coming from the part of the code that this PR doesn't touch (It complains about |
hanbyul-here
force-pushed
the
deprecate-old-explore
branch
2 times, most recently
from
f4ab2de to
119ea50
Compare
hanbyul-here
force-pushed
the
deprecate-old-explore
branch
from
119ea50 to
79b64bd
Compare
dzole0311
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
I tested as much as I could, also on the GHG side and couldn't spot any issues.
GHG Center preview: https://deploy-preview-611--ghg-demo.netlify.app/
sandrahoang686
approved these changes
Oct 5, 2024
Merged
snmln
added a commit
that referenced
this pull request
Oct 30, 2024
You can find VEDA Dashboard preview link to test these changes: NASA-IMPACT/veda-config#470 ## 🎉 Features - Cookie consent component: #1163, #1165, #1127, #1177 - Stories Hub export in #1162 - Expose As Is - PageHeader, LinkElement Prop & Logo in #1184 ## 🚀 Improvements - Add docs for registry dev in #1169 - Timeline date selection centering functionality in #1181 - Deprecate old explore page, Mapbox component #1176 - Update doc with new diagrams about general architecture in #1195 - Add playwright in #1139 - Pre-select AOIs that have the "selected" prop set to true in #1215 - ## 🐛 Fixes - Check dastaset analysis exclude attribute before running analysis in #1175 - Restrict dynamic colormaps to applicable layer types in #1183 - Fix external link badge display for tools hosted under the same domain in #1192 - Escape special characters in regex expression when searching datasets in #1204 ### New Contributors * @snmln made their first contribution in #1127 * @AliceR made their first contribution in #1204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: https://github.com/orgs/nasa-IMPACT/projects/17/views/6?pane=issue&itemId=78455497 (Sorry, never converted it into a proper issue)
Description of Changes
FEATURE_NEW_EXPLORATIONflag, Also deprecated some components that old pages use (DateSlider, Chart for analysis)Notes & Questions About Changes
Validation / Testing