Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of Vaccination, complexity not planned for #1015

Open
missyschoenbaum opened this issue Jul 21, 2020 · 7 comments
Open

Validation of Vaccination, complexity not planned for #1015

missyschoenbaum opened this issue Jul 21, 2020 · 7 comments

Comments

@missyschoenbaum
Copy link
Contributor

This is a problem because I asked for validation of entry on Control Protocols, vaccination when there is a vaccination ring present.

What I didn't consider is that users can make a control protocol for a species that doesn't get vaccinated. Since the ring is production type agnostic, it doesn't make sense to be validating. For example, I may vaccinate dairy cattle, but not vaccinate sheep, but sheep still are expecting valid parameters.

It is a "which comes first, the chicken or the egg" thing.

2 options

  1. Leave as is, it is very easy to make dummy parameters to get around validation. I would need to document.
  2. Completely turn off validation on Control Protocols, vaccination

Any thoughts?

@BryanHurst
Copy link
Contributor

I think either approach is acceptable for now. Disabling that validation should be easy, so whichever approach you prefer.

@missyschoenbaum
Copy link
Contributor Author

I'm for whatever is easiest.

@BryanHurst
Copy link
Contributor

@ConradSelig can you disable this validation?

@ConradSelig
Copy link
Contributor

OK @missyschoenbaum need your input here.

I can do a "soft" validation removal here, it looks like this:
image
My preview for this image looks really bad but if I open it in its own tab it looks fine.
However the scenario will still validate and run. The only time the Control Protocol tab on the left turns yellow is if the tab is open - switch to another page and it will show green.

I can also get it to remove the red warnings and show green on the "Control Protocol" tab if you would like that better. Up to you.

@missyschoenbaum
Copy link
Contributor Author

@ConradSelig let's do remove the red warnings and show green on the "Control Protocol" tab.

@ConradSelig
Copy link
Contributor

OK @BryanHurst this one is ready for you when you get to it Monday. My Zenhub is down at the moment so I'm not sure what pipeline this ticket is in right now sorry.

@missyschoenbaum
Copy link
Contributor Author

This works as stated and expected. I may write a known bug on it to explain why you get yellow while on tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants