-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation of Vaccination, complexity not planned for #1015
Comments
I think either approach is acceptable for now. Disabling that validation should be easy, so whichever approach you prefer. |
I'm for whatever is easiest. |
@ConradSelig can you disable this validation? |
OK @missyschoenbaum need your input here. I can do a "soft" validation removal here, it looks like this: I can also get it to remove the red warnings and show green on the "Control Protocol" tab if you would like that better. Up to you. |
@ConradSelig let's do remove the red warnings and show green on the "Control Protocol" tab. |
OK @BryanHurst this one is ready for you when you get to it Monday. My Zenhub is down at the moment so I'm not sure what pipeline this ticket is in right now sorry. |
This works as stated and expected. I may write a known bug on it to explain why you get yellow while on tab. |
This is a problem because I asked for validation of entry on Control Protocols, vaccination when there is a vaccination ring present.
What I didn't consider is that users can make a control protocol for a species that doesn't get vaccinated. Since the ring is production type agnostic, it doesn't make sense to be validating. For example, I may vaccinate dairy cattle, but not vaccinate sheep, but sheep still are expecting valid parameters.
It is a "which comes first, the chicken or the egg" thing.
2 options
Any thoughts?
The text was updated successfully, but these errors were encountered: