Fix null stride problem in netCDF-4.6.2 #1325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I had to delete and recreate the develop branch, but now this is working in my CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a mistake I made netCDF 4.6.2 segfaults when presented with a NULL stride parameter. Whoops! Sorry about that. (It is fixed in netCDF for future releases, but 4.6.2 is out there.)
In this PR I use the same fake_stride solution formerly used for pnetcdf only. Now it is used for pnetcdf and netcdf.
This has been merged to develop for testing.
Fixes #1320.
Fixes #1326.