Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build tests timing out issue #205

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Fix Build tests timing out issue #205

merged 2 commits into from
Mar 15, 2022

Conversation

erogluorhan
Copy link
Collaborator

@erogluorhan erogluorhan commented Mar 15, 2022

Essentially fixes the build tests timing out issue through addressing "UserWarning: Passing an object to dask.array.from_array which is already a Dask collection. This can lead to unexpected behavior." in interpolation.py.

PR also fixes "np.float Deprecated" warnings in meteorology.py and test_meteorology.py files

…is already a Dask collection. This can lead to unexpected behavior
Copy link
Contributor

@pilotchute pilotchute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though this wouldn't work for numpy arrays. The type hints in the function signature are for xarrays though, so I see no reason not to approve.

@erogluorhan
Copy link
Collaborator Author

Looks good, though this wouldn't work for numpy arrays. The type hints in the function signature are for xarrays though, so I see no reason not to approve.

Great point! I initially designed this function to work only with Xarray, so, I agree, we wouldn't have a problem regarding Numpy for now (I was planning to look into the function to explore if we should Numpy as well; let me know if you have any thoughts)

One more thing: I added a small side-fix to this PR (np.float Deprecations; look at my PR description) simultaneously with your approval. Please let me know if you are still fine with your approval when the current build tests succeed again

@erogluorhan erogluorhan requested a review from pilotchute March 15, 2022 17:29
@pilotchute
Copy link
Contributor

Yes, the small depreciated types fix meets my approval. :)

@erogluorhan erogluorhan merged commit fb7dda3 into main Mar 15, 2022
@erogluorhan erogluorhan deleted the fix_interp_sigma branch March 15, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants