Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov coverage reports #446

Merged
merged 9 commits into from
Aug 23, 2023
Merged

Fix codecov coverage reports #446

merged 9 commits into from
Aug 23, 2023

Conversation

anissa111
Copy link
Member

@anissa111 anissa111 commented Aug 23, 2023

PR Summary

Closes #444

Summary of changes:

  • Fixes codecov coverage by using an editable install of geocat-comp
  • Removed redundant namespace and coverage tests, combining them into one test run that outputs a coverage report
  • Adds artifacts for test outputs

See fixed coverage report on my fork.

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.

@anissa111 anissa111 added bug Something isn't working testing Issue related to testing labels Aug 23, 2023
@anissa111 anissa111 requested a review from kafitzgerald August 23, 2023 03:13
@anissa111 anissa111 merged commit d4525ce into NCAR:main Aug 23, 2023
@anissa111 anissa111 deleted the issue444 branch August 23, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing Issue related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test coverage reporting incorrect
2 participants