Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include xarray pinning in setup.cfg #458

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Conversation

anissa111
Copy link
Member

@anissa111 anissa111 commented Sep 8, 2023

PR Summary

Closes #453

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.

@anissa111 anissa111 added the dependencies Pull requests that update a dependency file label Sep 8, 2023
Copy link
Contributor

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this in! I should've just done this yesterday when it came up, but oh well - thank you.

And looks good. If this fails, we've got bigger problems.

@anissa111
Copy link
Member Author

Thanks for getting this in! I should've just done this yesterday when it came up, but oh well - thank you.

And looks good. If this fails, we've got bigger problems.

Haha, it will fail if a make a link typo 😅

@anissa111 anissa111 merged commit 6479a1b into NCAR:main Sep 8, 2023
@anissa111 anissa111 deleted the issue453 branch September 8, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include version pins in setup.cfg
2 participants