Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOF Unsigned Vector Tests #516

Merged
merged 6 commits into from
Nov 20, 2023
Merged

EOF Unsigned Vector Tests #516

merged 6 commits into from
Nov 20, 2023

Conversation

cyschneck
Copy link
Contributor

@cyschneck cyschneck commented Nov 15, 2023

PR Summary

Closes #463 and #131

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.
  • If needed, squash and merge PR commits into a single commit to clean up commit history

@cyschneck cyschneck self-assigned this Nov 15, 2023
@cyschneck cyschneck added support Support request opened by outside user/collaborator testing Issue related to testing labels Nov 15, 2023
@cyschneck cyschneck marked this pull request as ready for review November 16, 2023 19:10
@cyschneck
Copy link
Contributor Author

cyschneck commented Nov 16, 2023

Should be merged with #460 for running with windows-latest

Copy link
Contributor

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, looks good to me.

docs/release-notes.rst Show resolved Hide resolved
@anissa111 anissa111 merged commit f0f6230 into NCAR:main Nov 20, 2023
8 checks passed
@cyschneck cyschneck deleted the eof_windows_463 branch November 29, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support Support request opened by outside user/collaborator testing Issue related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EOF tests are failing in CI for Windows
3 participants