Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize and improve ci-release.yml #531

Merged
merged 11 commits into from
Dec 27, 2023

Conversation

anissa111
Copy link
Member

@anissa111 anissa111 commented Dec 15, 2023

PR Summary

Part of #456

Summary of changes

  • standardizes name of action to match others
  • updates concurrency detection and cancellation
  • adds pypi releases to check
  • switches to micromamba for environment creation
  • removes unnecessary token use for concurrency and checkout
  • adds if check to only run on NCAR/geocat-comp on main

See these forked logs for verification

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.
  • If needed, squash and merge PR commits into a single commit to clean up commit history

@anissa111 anissa111 added the testing Issue related to testing label Dec 15, 2023
@anissa111 anissa111 marked this pull request as ready for review December 15, 2023 20:37
@anissa111 anissa111 mentioned this pull request Dec 15, 2023
7 tasks
anissa111 added a commit to anissa111/geocat-comp that referenced this pull request Dec 15, 2023
@anissa111 anissa111 merged commit c2f90a3 into NCAR:main Dec 27, 2023
12 checks passed
@anissa111 anissa111 deleted the improve-release-ci branch December 27, 2023 17:31
anissa111 added a commit that referenced this pull request Dec 28, 2023
* pull into clean branch

* add to release notes

* pull updated ci-release.yml from #531

* add retry env creation to ci-release.yml

* and retry env setup for upstream-dev-ci.yml

* add retry around upstream test runs

* force a failure to test retry

* [no-ci] remove partial micromamba install if exists

* [no-ci] remove partial micromamba install if exists

* try don't redownload instead

* add environment retry for other CI files

* add env retry to benchmarking

* remove env name for benchmarking

* add env and test retry to benchmarks

* remove shell from benchmarks step

* nevermind actually, we don't need to retry the benchmarks like that
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issue related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants