Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to PyPI Trusted Publishing #534

Merged
merged 5 commits into from
Dec 28, 2023
Merged

Conversation

anissa111
Copy link
Member

@anissa111 anissa111 commented Dec 15, 2023

PR Summary

Closes #533

This PR just removes the user and password from the pypi action, but I've also added the workflow/repo as a trusted publisher on PyPI

image

I'm not exactly sure how to test this, but I'm pretty sure this is correct based these docs.

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.
  • If needed, squash and merge PR commits into a single commit to clean up commit history

@anissa111 anissa111 added developer feature For development standardization / best practices / enhancement testing Issue related to testing labels Dec 15, 2023
Copy link
Contributor

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@anissa111 anissa111 merged commit 1c9c605 into NCAR:main Dec 28, 2023
12 checks passed
@anissa111 anissa111 deleted the pypi-trusted branch December 28, 2023 20:23
@erogluorhan
Copy link
Collaborator

I believe the "PYPI_PASSWORD" secret can now be removed from this repo's settings as this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer feature For development standardization / best practices / enhancement testing Issue related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch PyPI publishing to Trusted Publishing
3 participants