-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geocat-comp ruff cleanup #584
Conversation
Currently:
The os is not being used in conf.py, but there is reference to how it could be used if there was a need. Should it be removed? The other two for conf.py are because the imports happen after the comment block, is it alright to move them above the template comment block? climatologies.py does need cf_xarray (
|
geocat/comp/interpolation.py
Outdated
@@ -1,6 +1,5 @@ | |||
import typing | |||
|
|||
import cf_xarray |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do actually need the cf_xarray
imports. They aren't "used"/called directly, but provide an accessor to some xarray objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me aside from the cf_xarray bit Anissa already caught!
* ruff clean up of unused imports * update release-notes.rst * replace required cf_xarray
PR Summary
Closes #583
PR Checklist
General
closes #XXX
to the PR description where XXX is the number of the issue.docs/release-notes.rst
in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecatedprecommit
. To set up on your local, runpre-commit install
from the top level of the repository. To manually run pre-commits, usepre-commit run --all-files
and re-add any changed files before committing again and pushing.