Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stomatal resistance incorrectly dependent on vegetation fraction #92

Open
barlage opened this issue Jun 7, 2023 · 6 comments
Open

Stomatal resistance incorrectly dependent on vegetation fraction #92

barlage opened this issue Jun 7, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@barlage
Copy link
Collaborator

barlage commented Jun 7, 2023

The radiation absorbed by the canopy is a grid quantity and therefore so is PAR (sunlit and shaded). When PAR is used to calculate stomatal resistance, this results in a vegetation fraction dependence on stomatal resistance. A quick test by dividing PAR by vegetation fraction in the inputs to stomatal resistance corrects this dependence so there are two possible solutions:

  1. remove the scaling of PAR before sending to stomatal resistance calculation
  2. a more general but larger solution (and I think preferable) is to remove the scaling on canopy absorbed radiation and apply it later when the grid average components are done at the end of the energy routine.
@barlage
Copy link
Collaborator Author

barlage commented Jun 8, 2023

I will also note that in NoahMP PAR is used in the Noah scheme equivalent canres, while in Noah canres the input is total SWdown so the parameters likely need to be recalibrated for this difference.

@jesusff jesusff mentioned this issue Jun 27, 2023
Closed
jesusff added a commit to CORDEX-WRF-community/WRF that referenced this issue Jun 29, 2023
@jesusff
Point NoahMP to CORDEX WRF community version
4853f1f 
so we can incorporate bug fixes as mentioned in CORDEX-WRF-community/euro-cordex-cmip6#2
Note that NCAR/noahmp#92 is still pending
@cenlinhe cenlinhe added the bug Something isn't working label Jul 1, 2023
@jesusff
Copy link

jesusff commented Oct 5, 2023

Dear @cenlinhe

you provided a fix for this (a7dd399) in the refactored code:

https://github.com/NCAR/noahmp/blob/107215a/src/ResistanceCanopyStomataBallBerryMod.F90#L98-L109

But I cannot find the corresponding code in the non-refactored code to mimic it. It should be around here:

https://github.com/NCAR/noahmp/blob/release-v4.5-WRF/src/module_sf_noahmplsm.F#L5076-L5085

but there was no index for shade/sunlit in the non-refactored code. We are trying to fix these issues for our CORDEX runs with WRF. Any hint is appreciated :-)

@cenlinhe
Copy link
Collaborator

@jesusff Sorry for the confusion. I have not included the update/fix in the non-refactored code yet. I will do it this week by updating the v4.5 branch.

@cenlinhe
Copy link
Collaborator

cenlinhe commented Oct 18, 2023 •
edited
Loading

@jesusff I have fixed this issue in this commit in release-v4.5-WRF branch: 0fd17e5
The fix in v5.0 (included in release-v5.0.1) is in this commit: a7dd399

@jesusff
Copy link

jesusff commented Oct 19, 2023

Thanks a lot @cenlinhe for the fixes to this and #91 in the old code. Much appreciated!
We'll be testing them into long-term WRF runs.

jesusff added a commit to CORDEX-WRF-community/noahmp that referenced this issue Oct 19, 2023
@jesusff
Merge branch 'release-v4.5-WRF' of github.com:NCAR/noahmp into v4.5.1…
5fe2e72 
…-devel

To include fixes for NCAR#91, NCAR#92, SLUCM ground flux and snow combination layer index
jesusff added a commit to CORDEX-WRF-community/WRF that referenced this issue Oct 19, 2023
@jesusff
Fixes for noahmp
5be4f00 
Applied to the noahmp non-refectored code, but not yet in the official
NCAR WRF release. These include:

 * NCAR/noahmp#92 (Stomatal resistance incorrectly dependent on FVEG)
 * NCAR/noahmp@218eb5a7 (snow combination layer index)
 * NCAR/noahmp@a26f91fb (ground heat flux sign in urban diagnostic; affects sf_urban_physics = 1 ! SLUCM)
@cenlinhe
Copy link
Collaborator

@jesusff I found a minor issue in my previous bug fix for this FVEG scaling. I updated the code further: 4ecebec

@cenlinhe cenlinhe mentioned this issue Oct 22, 2023
Merged
jesusff added a commit to CORDEX-WRF-community/WRF that referenced this issue Nov 30, 2023
@jesusff
further bug fix for FVEG scale in stomatal resistance
ca55db0 
This includes NCAR/noahmp@4ecebec (see
NCAR/noahmp#92 and wrf-model#1929)
weiwangncar pushed a commit to wrf-model/WRF that referenced this issue Jan 13, 2024
@cenlinhe
Bug fix for Noah-MP snow, vegetation and urban (#1929)
ce1069f 
TYPE: bug fix

KEYWORDS: Noah-MP, snow combine, vegetation fraction scaling, urban ground heat flux

SOURCE: Cenlin He (NCAR/RAL)

DESCRIPTION OF CHANGES:
There are a few bug fixes for Noah-MP related processes:
(1) the snow layer index in snow COMBINE module was wrong, causing model crash when snow layer changes by more than 1 layer within one timestep; This has been fixed by using the correct layer index. 
(2) the ground heat flux sign in Noah-MP column model (positive: downward) is inconsistent with that in urban canopy model (positive: upward), leading to wrong diagnostic grid-mean ground heat flux calculation for urban grid. This only affects the diagnostic value for output. See this issue: #1921 and NCAR/hrldas#114
(3) there is a bug in vegetation fraction (FVEG) scaling for stomata resistance calculation (NCAR/noahmp#92) and canopy interception calculation (NCAR/noahmp#91).

LIST OF MODIFIED FILES: list of changed files (use `git diff --name-status master` to get formatted list):
phys/noahmp/src/module_sf_noahmplsm.F
phys/noahmp/src/module_sf_noahmpdrv.F

TESTS CONDUCTED: 
1. Tested successfully in NCAR Cheyenne HPC for 13-km run over the entire CONUS region
2. The Jenkins tests are all passing.

RELEASE NOTE:  Noah-MP bug fix for snow combination, vegetation fraction scaling, and urban ground heat flux sign.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jesusff @barlage @cenlinhe