Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change numpy to np #283

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Change numpy to np #283

merged 2 commits into from
Jan 17, 2024

Conversation

davidhassell
Copy link
Contributor

Fixes #278

(No rush on this one!)

Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brill, thanks. As for closing #278, there are still some import numpy uses in the test suite, based on a git grep "import numpy" and eyeball to see if any lacked the as np at the end at this stage, but it seems you've caught all of the ones outside of it. But maybe we can change those too for this PR, whilst we are at it (though there's an argument to make those all, consistently, import numpy as opposed to the other way round given it is more explicit for testing and we don't seem to use many, if any, as aliases in the test suite at present)?

Either way, happy for you to merge this, though preferably we address the inconsistency in the imports in the test suite too first.

@davidhassell
Copy link
Contributor Author

Thanks Sadie. Test suite now updated to import numpy as np (82634e3).

Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidhassell for updating this. I've sanity-checked the extra commit and it's all fine, so please merge.

@davidhassell davidhassell merged commit 92f8fdd into NCAS-CMS:main Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always import numpy as np
2 participants