Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How will KPs handle qualifier_constraints? #328

Closed
edeutsch opened this issue May 16, 2022 · 2 comments
Closed

How will KPs handle qualifier_constraints? #328

edeutsch opened this issue May 16, 2022 · 2 comments
Milestone

Comments

@edeutsch
Copy link
Collaborator

With new PR #327 KPs may receive QEdge.qualifier_constraints. How will they handle them?

Proposals:

A) (heart emoji) If a KP receives non-empty QEdge.qualifier_constraints, it MUST only return edges that satisfy the entire set of qualifier_constraints. If a KP does not yet support QEdge.qualifier_constraints, it MUST return an empty response because no matches are found.

B) (rocket emoji) If a KP receives non-empty QEdge.qualifier_constraints, it MUST only return edges that satisfy the entire set of qualifier_constraints. If a KP does not yet support QEdge.qualifier_constraints, it MUST return an ERROR condition to indicate that qualifier_constraints are not supported.

C) (eyes emoji) If a KP receives non-empty QEdge.qualifier_constraints, it MAY return edges that satisfy the unqualified edge.

Please comment and/or vote on this comment with an emoji as listed above. Feel free to describe a different proposal.

@brettasmi
Copy link
Contributor

I vote C, at least for now--I feel like it might be better to push this down the line until we're all implementing qualifiers and have a better sense of how that's working.

edeutsch added a commit that referenced this issue Aug 10, 2022
Proposal to clarify QEdge.qualifier_constraints obligations as discussed in #328, at TRAPI calls, and at Architecture calls.
edeutsch added a commit that referenced this issue Aug 10, 2022
@vdancik vdancik added this to the v1.3 milestone Aug 25, 2022
@edeutsch
Copy link
Collaborator Author

edeutsch commented Sep 6, 2022

addressed in PR #364

@edeutsch edeutsch closed this as completed Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants