Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update knowledge_level_agent_type_specification.md #459

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

mbrush
Copy link
Collaborator

@mbrush mbrush commented Sep 28, 2023

Added note about short term plans for knowledge level annotations.

@andrewsu
Copy link

Personally, I don't love the link out to a google doc. I would rather capture the relevant information in the MD file itself...

@mbrush
Copy link
Collaborator Author

mbrush commented Sep 28, 2023

Yes, I get that, and am happy to translate the information into the markdown file. But it’s just stopgap measure for a couple months, and I just wanted people to know that they come to the specifications for guidance, and be able to see read what is going on in the short term while the permanent solution is implemented.
This specification document is a work in progress anyway, and definitely won’t have the information referenced externally when it is finalized in the coming months

@edeutsch
Copy link
Collaborator

Modeling is still ongoing in the EPC calls. We discussed at TRAPI call 2023-10-12 and decided to leave this PR open until a fully fleshed-out markdown can be added to the PR.

@mbrush
Copy link
Collaborator Author

mbrush commented Jan 15, 2024

@edeutsch I made significant changes to the spec here to reflect its current state of implementation, which will complement the updated developer documentation I am creating. This includes addition of more information to the spec md itself, rather than relying on linkouts to gdocs (there are still linkouts, but only for more supplementation info). Can you approve/merge the PR?

Copy link
Collaborator

@edeutsch edeutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, thanks!

@edeutsch edeutsch merged commit f046863 into master Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants