-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1 #97
base: master
Are you sure you want to change the base?
Conversation
* Best effort will be made to reimplement ARAGORN, BTE, and ARAX to Shepherd. | ||
* ARS will continue to exist and does not require modifications based on the outlined plan for Shepherd. | ||
* It is possible to host non-Shepherd ARAs if desired and this PR does not exclude the possiblity. | ||
* Shepherd will access Translator knowledge providers via the Retriever interface. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something that David K brought up, but Shepherd will default to using the Retriever interface for any lookups (and we will strongly recommend this interface), but it's entirely possible that an ARA is able to access other knowledge providers or services outside of Retriever.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maximusunc I added a new line that ARAs can access their own internal stuff like databases. @dkoslicki do you think that this captures it or should it be more expansive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The databases part makes sense. And the It is possible to host non-Shepherd ARAs if desired and this PR does not exclude the possibility.
also leaves open the possibility of using an ARAX-style beam-search for lookups instead of retriever directly, like we talked about on the call. So both of these capture it in my mind.
PerformanceRefactor.md
Outdated
|
||
* We will create a shared platform for ARA implementation | ||
* The name of this platform is Shepherd | ||
* Shepherd will be implemented in python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The core of Shepherd will be implemented in python, but hopefully individual operations will be more language-agnostic and developers can make new operations in their preferred language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I aded a line to that effect. But I did say that python was preferred even in this case. FWIW, I think it's valuable to think about the operations as shared code so that we can have Translator-wide contributions. But I don't feel terribly strongly about it, if people hate it I can amend.
A document codifying the results of discussions at the start of the performance phase.