Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps and rename logging #52

Merged
merged 5 commits into from
May 24, 2023
Merged

Update deps and rename logging #52

merged 5 commits into from
May 24, 2023

Conversation

jdr0887
Copy link
Collaborator

@jdr0887 jdr0887 commented May 24, 2023

misc changes...

  • cohd was being discarded on startup due to timeout
  • smartapi.py main was erroring out due to ambiguous call to logging

@jdr0887 jdr0887 requested review from maximusunc and uhbrar May 24, 2023 17:35
maximusunc
maximusunc approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@maximusunc maximusunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@jdr0887 jdr0887 merged commit c633ecd into main May 24, 2023
@jdr0887 jdr0887 deleted the update_deps_and_rename_logging branch May 24, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximusunc maximusunc maximusunc approved these changes

@uhbrar uhbrar Awaiting requested review from uhbrar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdr0887 @maximusunc