Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon button style is broken in version 9 #4955

Closed
sasensi opened this issue Mar 30, 2020 · 5 comments · Fixed by #5025
Closed

Icon button style is broken in version 9 #4955

sasensi opened this issue Mar 30, 2020 · 5 comments · Fixed by #5025
Assignees

Comments

@sasensi
Copy link

sasensi commented Mar 30, 2020

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-button-v9-0-0-beta-3

Steps to reproduce

Create button with an icon but no text.

What is expected?

The button should be a square.

What is actually happening?

The button is a rectangle.

Environment Info
ng-zorro-antd 9.0.0-beta.3
Browser Chrome 80

The bug occurs with the new beta version and Angular 9.
This worked as expected with latest stable version (8.5.1) and Angular 8: https://stackblitz.com/edit/ng-zorro-antd-button-v8-5-1

@sasensi
Copy link
Author

sasensi commented Mar 30, 2020

@vthinkxie, your project shows a circular icon button, what I am talking about is the square icon button.

@vthinkxie
Copy link
Member

ng-zorro-antd v9 follow the antd v4 design spec, you can modify the less to customize the theme if you want.

@sasensi
Copy link
Author

sasensi commented Mar 30, 2020

Oh, ok, I don't really know how this spec works.
What I did is pick the example from the documentation:

screenshot-ng ant design-2020 03 30-14_54_56

So does this mean that this type of button won't no longer be available in v9 ?

@vthinkxie
Copy link
Member

sorry for misunderstanding your repo
we will add this type back soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants