refactor(module: resizable): change cursor styles #4584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to keep the style consistent, the cursors for col-resize should be change to ew-resize (row-resize to ns-resize).
|
This preview will be available after the TravisCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #4584 +/- ##
=======================================
Coverage 93.23% 93.23%
=======================================
Files 519 519
Lines 12822 12822
Branches 2013 2013
=======================================
Hits 11954 11954
Misses 452 452
Partials 416 416
Continue to review full report at Codecov.
|
|
@hsuanxyz Can we assign pull requests to the correct code owner like what we do to the issues? |
hsuanxyz
changed the title
hsuanxyz
approved these changes
Dec 23, 2019
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
In order to keep the style consistent, the cursors for col-resize should be change to ew-resize (row-resize to ns-resize).
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
In order to keep the style consistent, the cursors for col-resize should be change to ew-resize (row-resize to ns-resize).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to keep the style consistent, the cursors for col-resize should be changed to ew-resize (row-resize to ns-resize).
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
[col/row]and[ew/ns], which make the UI style inconsistent (e.g., on Windows).<body>element during MouseDown, it's hard to make a local patch using CSS only.
Issue Number: N/AWhat is the new behavior?
As screenshot above (both col-resize and row-resize are change to ew- and ns- like styles)
Does this PR introduce a breaking change?
Other information