XML table should gracefully handle empty nodes/elements

[ollietulloch]

Xml::Table checks that every xpath from an xml record is accounted for in column mappings, this means that empty nodes/sections require a column mapping

Example xml:

<root>
  <record>
    <no_relative_path value="A value"/>
    <no_path_or_att>Another value</no_path_or_att>
    <demographics>
      <demographics_1>AAA</demographics_1>
      <demographics_2 code="03">Inner text</demographics_2>
    </demographics>
    <pathology></pathology>
  </record>
</root>

The pathology section is empty, but would require a column mapping, that is set to do_not_capture, so that Xml::Table is happy the xpath is accounted for.

column mapping for pathology:

{ 'column' => 'pathology', 'klass' => 'SomeTestKlass',
   'xml_cell' => { 'relative_path' => '' },
   ' do_not_capture' => true }

This PR only requires a column mapping where the section/mode/elment is populated, and would mean the above column mapping wouldn't be required

[kenny-lee-1]

I think leaf may be old naming convention?

maybe

populated?(node)

[ollietulloch]

yep, agreed

[kenny-lee-1]

is this useable? https://www.rubydoc.info/github/sparklemotion/nokogiri/Nokogiri%2FXML%2FNode:blank%3F

[ollietulloch]

I don't think so

Given this xml, we'd expect pathology to be blank:

<root>
  <record>
    <no_relative_path value="A value"/>
    <no_path_or_att>Another value</no_path_or_att>
    <demographics>
      <demographics_1>AAA</demographics_1>
      <demographics_2 code="03">Inner text</demographics_2>
      <address></address>
    </demographics>
    <pathology></pathology>
  </record>
</root>

But blank? returns false.

[1] pry(#<NdrImport::Xml::Table>)> node
=> #(Element:0x1360 { name = "pathology" })
[2] pry(#<NdrImport::Xml::Table>)> node.blank?
=> false

[kenny-lee-1]

just update the name ofpopulated_leaf method? (and subsequent method calls)