XML file matadata #125
Merged
XML file matadata #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollietulloch
force-pushed
the
feature/xml_file_matadata
branch
from
2fa0380 to
d6c2c58
Compare
bshand
requested changes
Apr 10, 2024
There was a problem hiding this comment.
This broadly looks good to me. A few typos and corrections requested in individual comments.
Overall, I think, given how we use streaming only for files, it'll work fine, but it might be worth an additional test case, in which we have to try a second file encoding.
bshand
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows storage of XML metadata at the
Fileand thenTablelevel.Config in table mappings tells the file handler where the metadata is and what to label it as. The File handler then passes the metadata to the
Table, where it can be accessed downstream.This constitues a minor revision bump, functionality has been added in a backward compatible manner