-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add column/data zipping functionality #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me. I've identified one minor typo.
I don't know whether you want to add any sort of validations (or error handling in the mapping code), to deal with incomplete zip_order
entries or the absence of a split_char
.
Yep, I thought about this a bit. I think I may just update the code to check for
|
I've added 58a7b92 which ensures there is enough field config present before attempting to zip. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good.
This PR adds column zipping functionality to the mapper, where 2 (or more) columns can have their string values split by a given
split_char
and then be zipped together in a prescribed order.E.g. given this csv data
and this data:
This mapped_line would be produced: