Capture column names and Regex column name matching #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollietulloch
changed the title
kenny-lee-1
reviewed
Nov 29, 2024
kenny-lee-1
reviewed
Dec 3, 2024
kenny-lee-1
reviewed
Dec 3, 2024
test/table_test.rb
Outdated
| test 'should mutate regexp column names' do | ||
| lines = [ | ||
| %w[1234 STRING_HEADING ABC123], | ||
| %w[NUMRIC_ONLY STRING_VALUE ALPHA_NUMBERIC] |
kenny-lee-1
reviewed
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two pieces of funtionality.
Regex column names:
This allows regex matching of column names where column name(s) may change slightly between files. If the regex matches the column header, the data will be mapped as usual. If the regex doesn't match, an invalid header error will be raised.
Capturing column names as data
Column names may contain data themselves, configuring
map_columname_toat the column level will add the column name to each row of mapped data. It does not include any of the more sophisticated mapping functionality that other fields have, e.g. joining fields, cleaning values etc.vcf/table_test.rbincludes a test that combines both of these.