Allow user to erase classes from option more easily #341
Conversation
✅ Deploy Preview for tts-fe-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Nice work :) . I have only one small concern I have noticed that if I choose one option, lock it and then I click the "limpar" button that option will be empty and locked without the possibility of unlocking. Imo one easy solution would be to add "locked: false" to each course option.
First of all, thank you and thanks for the suggestion. If you have have any other suggestions, please share them :) |
There was a problem hiding this comment.
Great work! 🚀
I just have one small thing to point out. I don't think it makes sense for the "Limpar" button to be visible when there is no class chosen in the current selectedOption entry inside the multipleOptions array.
I believe you just have to check if all of the entries inside multipleOptions[selectedOption].course_options are null and if so don't show the button
I also agree with that |
To be honest, I don’t see an issue with this approach. It makes the layout more consistent, as it avoids frequently removing and re-adding the "Limpar" button. While clearing all options when none are selected might seem unnecessary, having the option available still makes sense for consistency and usability. Additionally, there are similar examples in tts—for instance, when selecting course units, the "Limpar" button remains visible even if no course units are selected. |
Thank you for addressing the changes :) Regarding the filtered teachers I also think that the current approach is fine and is consistent with the "remover seleção" option in the dropdown which also doesn't reset the filtered teachers. |
That is no longer the case since PR #336 was merged into develop. I agree that it is worse for consistency, but I don't think the changes will be that frequent since the "Limpar" button will not be one of the main things the users will be interacting with while choosing classes. |
I wasn’t referring to the "Remover Seleção" button; I was referring to the actual "Limpar" button in the CoursePicker. The "Remover Opção" button is fine because the user doesn’t actively see it disappearing—initially it isn't there, then you select an option and the next time you go there , the button appears. However, with the "Limpar" button, it would appear and disappear in front of the user. While this might not happen very often and may not be a significant issue, I’m still more inclined to leave it as it is. |
|
I've decided to agree wtih you @jose-carlos-sousa The "remover seleção" were occupying useful space in the dropdown so that's why they were removed. However, this is not occupying that much space and will not be there for very long as the users will start choosing course units right away |
|
I have been closely following this discussion (even mentioning it in person to @jose-carlos-sousa). I tried to apply the same logic used in the CoursePicker modal, and, in my opinion, it makes more sense for the button to always stay visible. |
Erase classes easily
Added a button that erases all selected classes in the current option.
Design is based on the button from the CoursePicker modal.
Let me know your thoughts :)
(after approval) closes #319