Feature/library reservations #1073
Conversation
…ect-schrodinger into feature/library-rooms
…o feature/library-reservations
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1073 +/- ##
========================================
- Coverage 16% 16% -0%
========================================
Files 227 236 +9
Lines 6862 7083 +221
========================================
+ Hits 1073 1084 +11
- Misses 5789 5999 +210 |
uni/lib/controller/local_storage/database/app_library_reservation.dart
Outdated
Show resolved
Hide resolved
| ); | ||
| } | ||
| late TabController tabController; | ||
| late List<Tab> tabs; |
There was a problem hiding this comment.
Why does this need to be late?
There was a problem hiding this comment.
Both depend on the context so i initialize them on getBody()
| boxShadow: const [ | ||
| BoxShadow( | ||
| color: Color.fromARGB(0x1c, 0, 0, 0), | ||
| blurRadius: 7, | ||
| offset: Offset(0, 1), | ||
| ), | ||
| ], | ||
| ), |
There was a problem hiding this comment.
Do we need to do this manually? Can't we use the GenericCard widget?
There was a problem hiding this comment.
That code is already on develop. I just changed the file. Maybe it's better to handle this in a separate issue.
niaefeup-admin
force-pushed
the
develop
branch
from
417c250 to
bd61b50
Compare
|
According to the new app's structure, I put the reservations card in the faculty page after the calendar.
|
|
There should only be one library card in the aggregate page, IMO. |
This is a good topic of discussion. I think it's best to keep as is for this release and reiterate on this idea from a UI standpoint. |
|
Let's drop this for this release, then. |
Duplicate of #658
Fetch and display reserved rooms.
At the time these changes were merged into
feature/library-reservations. This should probably be reviewed again though.