Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: proper error handling in plausible provider #1185

Merged

Conversation

limwa
Copy link
Member

@limwa limwa commented Mar 5, 2024

This PR adds proper error handling code to PlausibleProvider to protect from situations where devices don't implement battery save mode capabilities. If a device doesn't implement them, we consider that the device never is in battery saving mode.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@limwa limwa changed the title Limwa/hotfix/proper error handling in plausible provider hotfix: proper error handling in plausible provider Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #1185 (1cc7990) into master (e2e949f) will decrease coverage by 0%.
Report is 1 commits behind head on master.
The diff coverage is 0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1185   +/-   ##
======================================
- Coverage      16%     16%   -0%     
======================================
  Files         229     229           
  Lines        6951    6958    +7     
======================================
  Hits         1086    1086           
- Misses       5865    5872    +7     

@bdmendes bdmendes enabled auto-merge March 5, 2024 19:58
@bdmendes bdmendes merged commit 396156c into master Mar 5, 2024
6 checks passed
@bdmendes bdmendes deleted the limwa/hotfix/proper-error-handling-in-plausible-provider branch March 5, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants