Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: launch url with toast #1186

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Conversation

limwa
Copy link
Member

@limwa limwa commented Mar 5, 2024

Fixes an issue where the future returned by canLaunchUrl was being cast to a bool. Also refactors every launchUrl to use launchUrlWithToast.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@limwa limwa changed the title Limwa/hotfix/launch url with toast hotfix: launch url with toast Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #1186 (8b2e33f) into master (e2e949f) will increase coverage by 1%.
Report is 1 commits behind head on master.
The diff coverage is 0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1186   +/-   ##
======================================
+ Coverage      16%     16%   +1%     
======================================
  Files         229     229           
  Lines        6951    6950    -1     
======================================
  Hits         1086    1086           
+ Misses       5865    5864    -1     

@bdmendes bdmendes enabled auto-merge March 5, 2024 19:58
@bdmendes bdmendes merged commit 5365aab into master Mar 5, 2024
6 checks passed
@bdmendes bdmendes deleted the limwa/hotfix/launch-url-with-toast branch March 5, 2024 21:16
LuisDuarte1 pushed a commit that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants