Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: send request information for bus debug #1198

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

limwa
Copy link
Member

@limwa limwa commented Mar 7, 2024

This PR sends more debug information to Sentry so we can understand what is going on with STCP's website on some occasions.

Currently, some requests to STCP fail because uni can't find a CSRF token on the website. With this change, we'll send the request body and URL to Sentry for further analysis.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #1198 (86649b0) into master (ff4e87e) will decrease coverage by 0%.
Report is 1 commits behind head on master.
The diff coverage is 0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1198   +/-   ##
======================================
- Coverage      17%     17%   -0%     
======================================
  Files         229     229           
  Lines        6974    6979    +5     
======================================
- Hits         1151    1144    -7     
- Misses       5823    5835   +12     

@limwa limwa requested a review from LuisDuarte1 March 8, 2024 18:25
@limwa limwa force-pushed the limwa/refactor/send-request-information-for-bus-debug branch from 126188f to 86649b0 Compare March 8, 2024 18:25
@limwa limwa enabled auto-merge March 8, 2024 20:21
@limwa limwa merged commit d021f27 into master Mar 8, 2024
2 checks passed
@limwa limwa deleted the limwa/refactor/send-request-information-for-bus-debug branch March 8, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants