Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use flutter-version-file argument to subosito/flutter-action #1216

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

bartekpacia
Copy link
Collaborator

I contributed this feature to subosito/flutter-action. Now we don't have to use a separate yq step :-)

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@bartekpacia bartekpacia requested review from limwa and LuisDuarte1 April 1, 2024 02:40
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Merging #1216 (772bbbe) into develop (a0759fb) will not change coverage.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1216   +/-   ##
=======================================
  Coverage       17%     17%           
=======================================
  Files          229     229           
  Lines         6982    6982           
=======================================
  Hits          1145    1145           
  Misses        5837    5837           

Copy link
Member

@limwa limwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Congratulations on becoming a new maintainer of flutter-action 🚀

@bartekpacia bartekpacia requested review from thePeras and bdmendes April 1, 2024 14:41
@bdmendes bdmendes merged commit 5ec899f into develop Apr 1, 2024
6 checks passed
@bdmendes bdmendes deleted the flutter-action-migrate branch April 1, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants