-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: session logic #1283
refactor: session logic #1283
Conversation
9008091
to
62411af
Compare
packages/uni_app/lib/session/controller/refreshing_authentication_controller.dart
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1283 +/- ##
========================================
- Coverage 16% 11% -4%
========================================
Files 238 268 +30
Lines 7172 7303 +131
========================================
- Hits 1078 799 -279
- Misses 6094 6504 +410 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ 🛫
packages/uni_app/lib/sigarra/endpoints/html/authentication/login.dart
Outdated
Show resolved
Hide resolved
packages/uni_app/lib/sigarra/endpoints/api/authentication/login/response.dart
Outdated
Show resolved
Hide resolved
2eb9c2a
to
dd1b60b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the code is overall quite good (props to using a class-orineted approach for the API) but I still have some recommendations and questions. I also noticed that if I login with federated authentication, and then logout (even after closing the app), the login page will try to open my browser without me selecting anything.
packages/uni_app/lib/sigarra/endpoints/html/authentication/login/response.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job 🚀
Don't merge yet, there is an active discussion in slack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job here! Thanks for your effort, code is now much cleaner and well architectured 🚀
[ATTENTION. This is the Pull Request Template. Replace the two following lines with the indicated information and delete this one. Do not delete anything else]
Closes #[issue number]
[Description of the changes proposed in the pull request. Include steps to replicate the behavior and screenshots if UI is updated]
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change