Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: session logic #1283

Merged
merged 34 commits into from
Sep 12, 2024
Merged

refactor: session logic #1283

merged 34 commits into from
Sep 12, 2024

Conversation

limwa
Copy link
Member

@limwa limwa commented Jul 23, 2024

[ATTENTION. This is the Pull Request Template. Replace the two following lines with the indicated information and delete this one. Do not delete anything else]

Closes #[issue number]
[Description of the changes proposed in the pull request. Include steps to replicate the behavior and screenshots if UI is updated]

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@limwa limwa marked this pull request as draft July 23, 2024 21:50
@limwa limwa changed the title refactor: create FederatedSession and CredentialsSession refactor: session logic Jul 23, 2024
@limwa limwa force-pushed the refactor/sessions branch from 9008091 to 62411af Compare August 21, 2024 17:53
@limwa limwa marked this pull request as ready for review September 11, 2024 01:54
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 2.94840% with 395 lines in your changes missing coverage. Please review.

Project coverage is 11%. Comparing base (f6e0da3) to head (4d28139).
Report is 37 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #1283    +/-   ##
========================================
- Coverage       16%     11%    -4%     
========================================
  Files          238     268    +30     
  Lines         7172    7303   +131     
========================================
- Hits          1078     799   -279     
- Misses        6094    6504   +410     

Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 🛫

Copy link
Contributor

@Process-ing Process-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the code is overall quite good (props to using a class-orineted approach for the API) but I still have some recommendations and questions. I also noticed that if I login with federated authentication, and then logout (even after closing the app), the login page will try to open my browser without me selecting anything.

packages/uni_app/lib/session/flows/base/session.dart Outdated Show resolved Hide resolved
packages/uni_app/lib/utils/derived.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@Process-ing Process-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job 🚀

@limwa
Copy link
Member Author

limwa commented Sep 12, 2024

Don't merge yet, there is an active discussion in slack

Copy link
Collaborator

@DGoiana DGoiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job here! Thanks for your effort, code is now much cleaner and well architectured 🚀

@limwa limwa enabled auto-merge September 12, 2024 23:30
@limwa limwa merged commit 091eded into develop Sep 12, 2024
6 checks passed
@limwa limwa deleted the refactor/sessions branch September 12, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants