Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exams and transport backgrounds #1335

Merged
merged 2 commits into from
Sep 22, 2024
Merged

fix: exams and transport backgrounds #1335

merged 2 commits into from
Sep 22, 2024

Conversation

limwa
Copy link
Member

@limwa limwa commented Sep 20, 2024

Fixes the backgrounds of exam widgets and transport tabs.
This was caused by previous changes to the theme of the app, made in 9caa64e.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@limwa
Copy link
Member Author

limwa commented Sep 20, 2024 •
edited
Loading

Light Theme

Screenshot_20240920-220330~2.png

Screenshot_20240920-220322~2.png

Dark theme

Screenshot_20240920-220346~2.png

Screenshot_20240920-220341~2.png

@limwa limwa requested a review from a team September 20, 2024 21:13
@limwa
Copy link
Member Author

limwa commented Sep 20, 2024

Previous version

Screenshot_20240920-111909
Screenshot_2024-09-20-19-54-31-609-edit_pt up fe ni uni

@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 11%. Comparing base (8f38a64) to head (c66f7a7).
Report is 5 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff           @@
##           develop   #1335   +/-   ##
=======================================
- Coverage       11%     11%   -0%     
=======================================
  Files          269     269           
  Lines         7341    7339    -2     
=======================================
- Hits           802     801    -1     
+ Misses        6539    6538    -1

Process-ing
Process-ing approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@Process-ing Process-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 👍 2️⃣ 🤳

@limwa limwa enabled auto-merge September 21, 2024 00:03
@limwa limwa requested a review from a team September 21, 2024 18:59
@limwa limwa merged commit bcf93da into develop Sep 22, 2024
6 checks passed
@limwa limwa deleted the limwa/fix/exams-and-transports-backgrounds branch September 22, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePeras thePeras thePeras approved these changes

@Process-ing Process-ing Process-ing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@limwa @Process-ing @thePeras