Add keygen command. #9

ximon18 · 2024-10-17T15:09:32Z

WIP.

src/commands/keygen.rs

This reverts commit 643ab86. See: <#9 (comment)>

tertsdiepraam

Well done! It's not super pretty, but it's about what you can expect for so much IO. I'd love to see this tested before we merge this.

Cargo.toml

src/commands/keygen.rs

src/env/mod.rs

src/commands/keygen.rs

mozzieongit · 2024-11-28T14:02:28Z

src/commands/keygen.rs

+        // TODO: Attempt repeated generation to avoid key tag collisions.
+        let (secret_key, public_key) = common::generate(params)
+            .map_err(|err| format!("an implementation error occurred: {err}").into())
+            .context("generating a cryptographic keypair")?;


See: <#9 (comment)>

src/commands/keygen.rs

src/commands/mod.rs

src/env/mod.rs

src/util.rs

src/commands/keygen.rs

Keygen skeleton.

fdb4cb1

ximon18 requested a review from a team October 17, 2024 15:09

ximon18 mentioned this pull request Oct 17, 2024

Reimplement (some) ldns sub commands #3

Open

12 tasks

bal-e added 4 commits October 29, 2024 15:29

[keygen] Implement the basic features

c914a7c

[keygen] synchronize files before exiting

7dc6b82

[keygen] Add help documentation

5746c3b

[keygen] Generate '.ds' files for KSKs

0333288

bal-e self-assigned this Oct 29, 2024

bal-e added enhancement New feature or request needs-review labels Oct 29, 2024

bal-e marked this pull request as ready for review October 29, 2024 15:27

bal-e added 2 commits October 30, 2024 10:29

[keygen] Use 'display_as_bind()'

b313809

[keygen] Add support for symlinks (Unix only)

4f2fd8e

ximon18 mentioned this pull request Nov 5, 2024

Add private key file parsing and generation #5

Closed

bal-e added 2 commits November 11, 2024 20:00

Merge branch 'main' into keygen

51cdb1c

[keygen] Improve errors and support '.ds' symlinks

73550b4

mozzieongit reviewed Nov 14, 2024

View reviewed changes

src/commands/keygen.rs Outdated Show resolved Hide resolved

bal-e added 3 commits November 15, 2024 09:59

Implement ldns-specific parsing for 'keygen'

086246b

Merge branch 'main' into keygen

0ef9f0a

[keygen] Implement '-v' with version info

643ab86

tertsdiepraam reviewed Nov 15, 2024

View reviewed changes

src/commands/keygen.rs Outdated Show resolved Hide resolved

src/commands/keygen.rs Outdated Show resolved Hide resolved

bal-e added 2 commits November 15, 2024 10:20

[keygen] Add 'cfg(unix)' in ldns-parsing

a062704

[keygen] Correctly handle duplicate options in ldns parsing

d450192

tertsdiepraam reviewed Nov 15, 2024

View reviewed changes

src/commands/keygen.rs Outdated Show resolved Hide resolved

bal-e added 6 commits November 15, 2024 10:28

Revert "[keygen] Implement '-v' with version info"

f503fc8

This reverts commit 643ab86. See: <#9 (comment)>

Merge branch 'main' into keygen

a5052ac

[keygen] Integrate the use of 'Env'

76d604a

[workflows/ci] Add OpenSSL installation steps

bf09e96

[workflows/ci] Integrate OpenSSL for 'minimal_versions'

532a399

Merge branch 'main' into keygen

eb171c4

[keygen] Satisfy clippy

84977fb

bal-e requested a review from tertsdiepraam November 21, 2024 15:30

tertsdiepraam reviewed Nov 22, 2024

View reviewed changes

bal-e added 7 commits November 25, 2024 09:23

[keygen] Simplify symlink CLI

a2224e6

Merge branch 'main' into keygen

9772177

Add basic filesystem operations to 'Env'

4158fb8

[keygen] Use symlink ops provided by 'Env'

cf85404

[keygen] Add basic tests for argument parsing

114b931

[keygen] Add tests

4a3fb18

[keygen] Satisfy 'minimal-versions'

1a0aa79

tertsdiepraam reviewed Nov 26, 2024

View reviewed changes

src/commands/keygen.rs Outdated Show resolved Hide resolved

src/commands/keygen.rs Outdated Show resolved Hide resolved

src/commands/keygen.rs Outdated Show resolved Hide resolved

src/commands/keygen.rs Show resolved Hide resolved

src/env/mod.rs Outdated Show resolved Hide resolved

bal-e added 6 commits November 26, 2024 14:34

[keygen] Satisfy clippy

c531ec7

[keygen] Add Windows-specific missing branch

dbaf113

[keygen] Document parsing for 'symlink'

8bbd0f9

[keygen] Report error on '-r'

9752b69

[env] Refactor util fns into a 'util' module

59ca8d2

[keygen::symlink] Mark params as used, for Windows

fae388e

mozzieongit reviewed Nov 28, 2024

View reviewed changes

bal-e added 3 commits November 29, 2024 12:05

[keygen] Fix double error message

f8a545a

See: <#9 (comment)>

Merge branch 'main' into keygen

639a835

[keygen] Use 'Args::Report'

9e9aec2

tertsdiepraam reviewed Nov 29, 2024

View reviewed changes

src/commands/keygen.rs Show resolved Hide resolved

src/commands/mod.rs Show resolved Hide resolved

src/env/mod.rs Show resolved Hide resolved

src/util.rs Outdated Show resolved Hide resolved

src/commands/keygen.rs Outdated Show resolved Hide resolved

bal-e added 3 commits November 29, 2024 15:19

[keygen] Allow invalid HTML in docs for Clap

6a4646a

Use 'domain'-style imports

2ce049d

[keygen] Use uppercase for expected clap values

f5aba21

tertsdiepraam reviewed Dec 2, 2024

View reviewed changes

src/commands/keygen.rs Outdated Show resolved Hide resolved

tertsdiepraam approved these changes Dec 2, 2024

View reviewed changes

[keygen] use lowercase value names in Clap

faffc71

bal-e merged commit 617b623 into main Dec 2, 2024
29 checks passed

bal-e deleted the keygen branch December 2, 2024 10:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add keygen command. #9

Add keygen command. #9

ximon18 commented Oct 17, 2024

tertsdiepraam left a comment

mozzieongit Nov 28, 2024

Add keygen command. #9

Add keygen command. #9

Conversation

ximon18 commented Oct 17, 2024

tertsdiepraam left a comment

Choose a reason for hiding this comment

mozzieongit Nov 28, 2024

Choose a reason for hiding this comment