Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve archive file sizes. #982

Merged
merged 5 commits into from
Jan 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macOS-latest]
rust: [1.70.0, stable, beta]
rust: [1.73.0, stable, beta]
steps:
- name: Checkout repository
uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
name = "routinator"
version = "0.14.1-dev"
edition = "2021"
rust-version = "1.70"
rust-version = "1.73"
authors = ["NLnet Labs <[email protected]>"]
description = "An RPKI relying party software."
repository = "https://github.com/NLnetLabs/routinator"
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ ARG MODE=build
# ========
#
# Only used when MODE=build.
ARG BASE_IMG=alpine:3.18
ARG BASE_IMG=alpine:3.21


# CARGO_ARGS
Expand Down
2 changes: 1 addition & 1 deletion src/collector/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
// `Collector`, `Run`, and `Repository` types.
//
pub use self::base::{Collector, Cleanup, Run, Repository};
pub use self::rrdp::{HttpStatus, SnapshotReason};
pub use self::rrdp::{HttpStatus, RrdpArchive, SnapshotReason};

mod base;
mod rrdp;
Expand Down
7 changes: 3 additions & 4 deletions src/collector/rrdp/archive.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ use crate::config::Config;
use crate::error::RunFailed;
use crate::utils::archive;
use crate::utils::archive::{
Archive, ArchiveError, FetchError, OpenError, PublishError
Archive, ArchiveError, ArchiveStats, FetchError, OpenError, PublishError
};
use crate::utils::binio::{Compose, Parse};

Expand Down Expand Up @@ -81,10 +81,9 @@ impl RrdpArchive {
}

impl RrdpArchive {
pub fn verify(path: &Path) -> Result<(), OpenError> {
pub fn verify(path: &Path) -> Result<ArchiveStats, OpenError> {
let archive = archive::Archive::<RrdpObjectMeta>::open(path, false)?;
archive.verify()?;
Ok(())
Ok(archive.verify()?)
}

/// Loads an object from the archive.
Expand Down
2 changes: 1 addition & 1 deletion src/collector/rrdp/base.rs
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ impl Collector {
continue;
}
match RrdpArchive::verify(entry.path()) {
Ok(()) | Err(OpenError::NotFound) => { }
Ok(_) | Err(OpenError::NotFound) => { }
Err(OpenError::Archive(ArchiveError::Io(err))) => {
error!(
"Fatal: Failed to read RRDP repository archive\
Expand Down
1 change: 1 addition & 0 deletions src/collector/rrdp/mod.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#![allow(dead_code)]

pub use self::archive::RrdpArchive;
pub use self::base::{Collector, LoadResult, ReadRepository, Run};
pub use self::http::HttpStatus;
pub use self::update::SnapshotReason;
Expand Down
65 changes: 65 additions & 0 deletions src/operation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ pub enum Operation {
Update(Update),
PrintConfig(PrintConfig),
Dump(Dump),
ArchiveStats(ArchiveStats),
Man(Man),
}

Expand All @@ -93,6 +94,7 @@ impl Operation {
let app = Update::config_args(app);
let app = PrintConfig::config_args(app);
let app = Dump::config_args(app);
let app = ArchiveStats::config_args(app);
Man::config_args(app)
}

Expand Down Expand Up @@ -131,6 +133,11 @@ impl Operation {
Some(("dump", matches)) => {
Operation::Dump( Dump::from_arg_matches(matches, cur_dir)?)
}
Some(("archive-stats", matches)) => {
Operation::ArchiveStats(
ArchiveStats::from_arg_matches(matches)?
)
}
Some(("man", matches)) => {
Operation::Man(Man::from_arg_matches(matches)?)
}
Expand Down Expand Up @@ -167,6 +174,7 @@ impl Operation {
Operation::Update(cmd) => cmd.run(process),
Operation::PrintConfig(cmd) => cmd.run(process),
Operation::Dump(cmd) => cmd.run(process),
Operation::ArchiveStats(cmd) => cmd.run(process),
Operation::Man(cmd) => cmd.run(process),
}
}
Expand Down Expand Up @@ -255,6 +263,7 @@ impl Server {
if let Some(log) = log.as_ref() {
log.start();
}

let timeout = match LocalExceptions::load(
process.config(), true
) {
Expand Down Expand Up @@ -310,6 +319,11 @@ impl Server {
// to recalculate timeout.
let deadline = Instant::now() + timeout;

info!(
"Next validation run scheduled in {} seconds",
timeout.as_secs()
);

let end = loop {
let timeout = deadline.saturating_duration_since(
Instant::now()
Expand Down Expand Up @@ -1184,6 +1198,57 @@ impl Dump {
}


//------------ ArchiveStats --------------------------------------------------

/// Prints archive statistics.
#[derive(Clone, Debug, Parser)]
pub struct ArchiveStats {
/// Archive file.
#[arg(value_name = "PATH")]
archive: PathBuf,
}

impl ArchiveStats {
/// Adds the command configuration to a clap app.
pub fn config_args<'a: 'b, 'b>(app: clap::Command) -> clap::Command {
// config
app.subcommand(
ArchiveStats::augment_args(
clap::Command::new("archive-stats")
.about("Prints statics for an RRDP archive")
.after_help(AFTER_HELP)
)
)
}

/// Creates a command from clap matches.
pub fn from_arg_matches(matches: &ArgMatches) -> Result<Self, Failed> {
Ok(
<ArchiveStats as FromArgMatches>::from_arg_matches(
matches
).unwrap()
)
}

fn run(self, process: Process) -> Result<(), ExitError> {
use crate::collector::RrdpArchive;

process.switch_logging(false, false)?;
match RrdpArchive::verify(&self.archive) {
Ok(stats) => {
println!("RRDP archive {}:", self.archive.display());
stats.print();
Ok(())
}
Err(err) => {
eprintln!("Archive is corrupt: {err}");
Err(ExitError::Generic)
}
}
}
}


//------------ Man -----------------------------------------------------------

/// Show the manual page.
Expand Down
Loading
Loading