Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BeginScope should accept any type of KeyValuePair (Swallow exceptions) #229

Merged
merged 1 commit into from
Jul 22, 2018

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Jul 21, 2018

Added try-catch-logic to ensure BeginScope doesn't throw unexpectedly.

@codecov
Copy link

codecov bot commented Jul 21, 2018

Codecov Report

Merging #229 into master will decrease coverage by 0.66%.
The diff coverage is 71.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
- Coverage   72.05%   71.39%   -0.67%     
==========================================
  Files           6        6              
  Lines         365      374       +9     
  Branches       89       88       -1     
==========================================
+ Hits          263      267       +4     
- Misses         65       72       +7     
+ Partials       37       35       -2
Impacted Files Coverage Δ
src/NLog.Extensions.Logging/Logging/NLogLogger.cs 72.68% <71.87%> (-1.63%) ⬇️
...g.Extensions.Logging/Logging/NLogLoggerProvider.cs 94.28% <0%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f59232...2a1ec6f. Read the comment docs.

@304NotModified 304NotModified added this to the 1.2.1 milestone Jul 22, 2018
@304NotModified 304NotModified merged commit 7c08a84 into NLog:master Jul 22, 2018
@304NotModified
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants